New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEML7700 and VEML6030 light sensors #6067
Conversation
Hey there @latonita, CODEOWNERS = ["@latonita"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6067 +/- ##
==========================================
- Coverage 53.70% 53.50% -0.21%
==========================================
Files 50 50
Lines 9408 9515 +107
Branches 1654 1683 +29
==========================================
+ Hits 5053 5091 +38
- Misses 4056 4117 +61
- Partials 299 307 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
I got as far as wait_for_device
and decided to stop reviewing there as it will need quite a bit of reworking to be accepted in.
Please take a look at my comments below.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi @latonita Two suggestions I have They are minor changes so I didn't do a PR to you, but I think they are worth you considering. Anyway thanks a lot for developing the component - great work. |
@mrtoy-me thanks for taking a look and testing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thanks for working on this!
Thanks. There are several more PRs to review! :) |
What does this implement/fix?
Implements component for ambient light sensors from Vishay - VEML7700 and VEML6030
Types of changes
Related issue or feature (if applicable): fixes
esphome/feature-requests#2493
esphome/feature-requests#218
esphome/feature-requests#1915
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3525
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: