Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFC binary sensor platform #6068

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Jan 10, 2024

What does this implement/fix?

This implements an nfc binary_sensor platform for use with the PN71x0 components.
In the future, other NFC components (such as the PN532 or RC522) could be adapted to use it, as well.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3526

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
binary_sensor:
  - platform: nfc
    # ndef_contains: pulse
    tag_id: pulse
    # uid: 59-FC-AB-15
    name: MFC Tag

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (nfc) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (pn7150) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (pn7160) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e83c7d) 53.60% compared to head (0f39f8f) 53.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6068   +/-   ##
=======================================
  Coverage   53.60%   53.60%           
=======================================
  Files          50       50           
  Lines        9374     9374           
  Branches     1650     1650           
=======================================
  Hits         5025     5025           
  Misses       4050     4050           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit e35cab0 into esphome:dev Jan 16, 2024
56 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants