Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

negative values for all DHT22 variants #6074

Merged
merged 1 commit into from
Jan 12, 2024
Merged

negative values for all DHT22 variants #6074

merged 1 commit into from
Jan 12, 2024

Conversation

ssieb
Copy link
Member

@ssieb ssieb commented Jan 10, 2024

What does this implement/fix?

There appears to be a new variant of DHT22 with different negative value handling. This should cover all of them automatically.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#5322

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration (dht) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b783c0) 53.54% compared to head (a7c7c0f) 53.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6074   +/-   ##
=======================================
  Coverage   53.54%   53.54%           
=======================================
  Files          50       50           
  Lines        9374     9374           
  Branches     1650     1650           
=======================================
  Hits         5019     5019           
  Misses       4054     4054           
  Partials      301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbx81 kbx81 merged commit aa04a3c into esphome:dev Jan 12, 2024
55 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
@kbx81 kbx81 added this to the 2023.12.9 milestone Jan 21, 2024
@ssieb ssieb deleted the dht branch March 10, 2024 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dht22 negative temperatures calculated incorrectly
5 participants