New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hydreon_rgxx - add resolution option #6077
Conversation
Hey there @functionpointer, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6077 +/- ##
==========================================
+ Coverage 53.60% 53.70% +0.10%
==========================================
Files 50 50
Lines 9374 9403 +29
Branches 1650 1653 +3
==========================================
+ Hits 5025 5050 +25
- Misses 4050 4055 +5
+ Partials 299 298 -1 ☔ View full report in Codecov by Sentry. |
@functionpointer Have made the changes we talked about - How does this look to you now ? |
Looks great :) |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thanks.., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test3.yaml
should also contain resolution: low
for the RG_15 instance. This would add a test for the newly added option.
Co-authored-by: functionpointer <suspendfunction@gmail.com>
Thanks heaps for the review and suggested changes .. it was only a small change but I learned a lot |
What does this implement/fix?
The component currently implements high resolution. This change adds ability to optionally set resolution to either high or low .
Defaults to resolution high as component currently implements.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3529
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: