Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Pico-ResTouch-LCD-3.5 #6078

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Conversation

nielsnl68
Copy link
Contributor

@nielsnl68 nielsnl68 commented Jan 11, 2024

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#5324

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3542

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
display:
#Waveshare PICO 3.5 DISPLAY with ESP32-S3-PICO board.
  - platform: ili9xxx
    model: WSPICOLCD

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @clydebarrow, mind taking a look at this pull request as it has been labeled with an integration (ili9xxx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b2d76e) 53.68% compared to head (770854b) 53.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6078   +/-   ##
=======================================
  Coverage   53.68%   53.68%           
=======================================
  Files          50       50           
  Lines        9385     9385           
  Branches     1651     1651           
=======================================
  Hits         5038     5038           
  Misses       4048     4048           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probot-esphome probot-esphome bot removed the small-pr label Jan 12, 2024
@jesserockz
Copy link
Member

jesserockz commented Jan 14, 2024

Please add a docs PR for the new config option and model value

@nielsnl68
Copy link
Contributor Author

Please add a docs PR for the new config option and model value

Done!

@jesserockz jesserockz merged commit 8cd1798 into esphome:dev Jan 15, 2024
53 checks passed
@illigtr
Copy link

illigtr commented Jan 15, 2024

Guys, this issue is NOT resolved! I tested the new driver and it does NOT resolve the issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILI9XXX component no longer works with Waveshare Pico-ResTouch-LCD-3.5 or Waveshare 3.5inch RPi LCD (C) boards
5 participants