-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add last_operation to time based cover #6084
Feature add last_operation to time based cover #6084
Conversation
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @kroimon, mind taking a look at this pull request as it has been labeled with an integration ( |
I created my feature branch from tag https://github.com/esphome/esphome/tree/2023.12.5 because this is my docker containers version and the version I tested my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your branch onto the latest dev branch, there are a lot of unrelated changes in this PR.
7f80a26
to
85fa896
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6084 +/- ##
==========================================
- Coverage 53.70% 53.45% -0.26%
==========================================
Files 50 50
Lines 9408 9543 +135
Branches 1654 1685 +31
==========================================
+ Hits 5053 5101 +48
- Misses 4056 4131 +75
- Partials 299 311 +12 ☔ View full report in Codecov by Sentry. |
For some reason a normal rebase was not possible, so I recreated my feature branch derived from the current dev branch and make this one line change to corresponding file. I will try to test it with a current build. |
…"last_operation_"
85fa896
to
60ba804
Compare
What does this implement/fix?
I need to know the last operation of the cover when handle a cover STOP command, because the current_operation is already set to IDLE. With the last operation information I am able to decide which of the two buttons (UP and DOWN) for my Warema controller I have to press to stop the cover.
Types of changes
Related issue or feature (if applicable): fixes esphome/issues#4252
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: