Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide example devcontainer config for mdns and USB passthrough #6094

Merged
merged 5 commits into from Feb 20, 2024

Conversation

linkedupbits
Copy link
Contributor

What does this implement/fix?

This adds commented-out configuration for the devcontainer.json to enable mdns discovery of devices and local usb serial access. This makes using a devcontainer much easier when developing components.
Un-commenting the example code and rebuilding the container within VS Code is all that is required.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

enable mdns and attach to host USB Serial
install avahi-utils to support mdns discovery from host machine
Commented changes but left them in place for extension.
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0cbc06a) 53.69% compared to head (586ecb4) 53.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6094   +/-   ##
=======================================
  Coverage   53.69%   53.69%           
=======================================
  Files          50       50           
  Lines        9398     9398           
  Branches     1652     1652           
=======================================
  Hits         5046     5046           
  Misses       4053     4053           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit 4d8b5ed into esphome:dev Feb 20, 2024
55 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants