Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: negative temperatures on PMS5003T sensors #6100

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

aschmitz
Copy link
Contributor

What does this implement/fix?

Fixes negative temperatures on PMS5003T sensors, which had previously been interpreted as unsigned integers.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): Fixes esphome/issues#3814 for the PMS5003T (#6083 fixed it for the PMS5003ST, but missed the 5003T)

Pull request in esphome-docs with documentation (if applicable): No documentation update should be needed.

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

sensor:
  - platform: pmsx003
    type: PMS5003T
    uart_id: uart_pm
    temperature:
      id: pm_temperature
      name: "Temperature"

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cd1798) 53.68% compared to head (5fddbb7) 53.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6100   +/-   ##
=======================================
  Coverage   53.68%   53.68%           
=======================================
  Files          50       50           
  Lines        9385     9385           
  Branches     1651     1651           
=======================================
  Hits         5038     5038           
  Misses       4048     4048           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssieb ssieb merged commit 87cab92 into esphome:dev Jan 15, 2024
55 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
@jesserockz jesserockz added this to the 2023.12.9 milestone Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect readout for negative values for PMS5003T
5 participants