Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
RMT on ESP32 is no longer clocked with the ABP clock, which value were used in the
esp32_rmt_led_strip
component. In recent C6 (and probably couple previous)PLL_F80M_CLK
80 MHz clocks used, while earlierABP_CLK
was used, which is stated to be always 80 MHz for that case also, as stated in Tehnical Reference Manuals.This cause wrong timings in
esp32_rmt_led_strip
for chips like ESP32 C6 and most likely P4, H2, C5 and sometimes C2.To fix it, I suggest adding a constant missing from
esp-idf
framework, and using it istead.Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed:
References