Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AM2120 device type #6115

Merged
merged 3 commits into from
Jan 19, 2024
Merged

add AM2120 device type #6115

merged 3 commits into from
Jan 19, 2024

Conversation

alexbuit
Copy link
Contributor

@alexbuit alexbuit commented Jan 18, 2024

What does this implement/fix?

This update adds the am2120 temp+humidity sensor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3559

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
sensor:
  - platform: dht
    pin: GPIO36
    model: AM2120
    update_interval: 30s
    temperature:
      name: "Badkamer Temperature"
      accuracy_decimals: 1
    humidity:
      name: "Badkamer Humidity"

Checklist:

  • [ x] The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration (dht) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (045836c) 53.70% compared to head (c80c66a) 53.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6115   +/-   ##
=======================================
  Coverage   53.70%   53.70%           
=======================================
  Files          50       50           
  Lines        9389     9389           
  Branches     1651     1651           
=======================================
  Hits         5042     5042           
  Misses       4048     4048           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexbuit
Copy link
Contributor Author

documentation is in PR:
esphome/esphome-docs#3555

@jesserockz jesserockz mentioned this pull request Jan 18, 2024
1 task
@jesserockz
Copy link
Member

documentation is in PR: esphome/esphome-docs#3555

@alexbuit
I commented asking for a rebase of that PR, but then I looked at the contents and realised it is adding a whole new platform apge for a component that doesnt exist as this PR is only adding an extra model to the existing dht platform.

@jesserockz jesserockz merged commit 6561746 into esphome:dev Jan 19, 2024
56 of 57 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants