Add some components to the new testing framework (G) #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6178 +/- ##
=======================================
Coverage 53.71% 53.71%
=======================================
Files 50 50
Lines 9404 9404
Branches 1653 1653
=======================================
Hits 5051 5051
Misses 4055 4055
Partials 298 298 ☔ View full report in Codecov by Sentry. |
kbx81
force-pushed
the
add-new-tests-for-components-g
branch
from
5c23b10
to
216ee1a
Compare
jesserockz
reviewed
Mar 27, 2024
| pages: | ||
| - id: page1 | ||
| lambda: |- | ||
| it.rectangle(0, 0, it.get_width(), it.get_height()); |
There was a problem hiding this comment.
Just a note to say these should probably draw the graph, not just a rectangle.
But we can improve these tests in a further PR
jesserockz
reviewed
Mar 27, 2024
| pages: | ||
| - id: page1 | ||
| lambda: |- | ||
| it.rectangle(0, 0, it.get_width(), it.get_height()); |
There was a problem hiding this comment.
Same here for drawing the menu
jesserockz
approved these changes
Mar 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Add components beginning with the letter "G" to the new testing framework.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: