Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioesphomeapi to 21.0.2 #6188

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 6, 2024

needs https://github.com/esphome/aioesphomeapi/actions/runs/7804166800

What does this implement/fix?

Removes cryptography from requirements_optional.txt and adds it to requirements.txt as its not optional since aioesphomeapi needs it for noise.

Its important we pin cryptography because it tends to have breaking changes and we see problems like home-assistant/core#109804

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Removes cryptography from requirements_optional as its not
optional since aioesphomeapi needs it for noise
@bdraco bdraco closed this Feb 6, 2024
@bdraco bdraco reopened this Feb 6, 2024
@bdraco bdraco closed this Feb 6, 2024
@bdraco bdraco reopened this Feb 6, 2024
@bdraco bdraco closed this Feb 6, 2024
@bdraco bdraco reopened this Feb 6, 2024
@bdraco bdraco marked this pull request as ready for review February 6, 2024 19:01
@jesserockz jesserockz merged commit cfe16c9 into dev Feb 6, 2024
129 of 152 checks passed
@jesserockz jesserockz deleted the requirements_optional_crypto_is_not_optional branch February 6, 2024 19:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants