Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web_server support for v3 #6203

Merged
merged 3 commits into from Mar 20, 2024
Merged

Conversation

RFDarter
Copy link
Contributor

@RFDarter RFDarter commented Feb 9, 2024

What does this implement/fix?

Adds support for the verison 3 of the web_server.
The js file would need to be hosted at
https://oi.esphome.io/v3/www.js

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

esphome:
  name: simple

esp32:
  board: esp32dev
  framework:
    type: arduino

logger:
  level: DEBUG

wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password

web_server:
  version: 3

button:
  - platform: template
    name: My Button

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (061d5b4) 53.71% compared to head (4c80887) 53.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6203   +/-   ##
=======================================
  Coverage   53.71%   53.71%           
=======================================
  Files          50       50           
  Lines        9404     9404           
  Branches     1653     1653           
=======================================
  Hits         5051     5051           
  Misses       4055     4055           
  Partials      298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending merge/release of webserver code

@jesserockz jesserockz added this to the 2024.3.0b4 milestone Mar 18, 2024
@jesserockz jesserockz modified the milestones: 2024.3.0b4, 2024.3.0b5 Mar 19, 2024
@jesserockz jesserockz merged commit 7e8e658 into esphome:dev Mar 20, 2024
56 of 57 checks passed
jesserockz pushed a commit that referenced this pull request Mar 20, 2024
@jesserockz jesserockz mentioned this pull request Mar 20, 2024
@jesserockz jesserockz mentioned this pull request Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants