Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 1.8V-powered devices #6234

Merged

Conversation

bisbastuner
Copy link
Contributor

@bisbastuner bisbastuner commented Feb 16, 2024

What does this implement/fix?

The BME680 sensor can be powered from 1.71V to 3.6V. BOSCH provides different configuration arrays for the BSEC library configuration, based on the sensor supply voltage. The Pimoroni PIM357 breakout module for BME680 (https://shop.pimoroni.com/products/bme680-breakout) powers the sensor at 1.8V, and using the 3.3V config arrays results in bad readings for the IAQ value.
This adds support for configuring the supply voltage of the BME680 sensor, defaulting to 3.3V

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3607

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
bme680_bsec:
  id: bme680_interno
  i2c_id: "i2cbus_bme"
  address: 0x77
  supply_voltage: 1.8v
  sample_rate: ulp
  temperature_offset: 2.9

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

The BME680 sensor can be powered from 1.71V to 3.6V. BOSCH provides different configuration arrays for the BSEC library configuration, based on the sensor supply voltage. The Pimoroni PIM357 breakout module for BME680 (https://shop.pimoroni.com/products/bme680-breakout) powers the sensor at 1.8V, and using the 3.3V config arrays results in bad readings for the IAQ value.
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27a3a08) 53.71% compared to head (fb527bd) 53.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6234   +/-   ##
=======================================
  Coverage   53.71%   53.71%           
=======================================
  Files          50       50           
  Lines        9404     9404           
  Branches     1653     1653           
=======================================
  Hits         5051     5051           
  Misses       4055     4055           
  Partials      298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bisbastuner bisbastuner marked this pull request as ready for review February 16, 2024 13:10
@probot-esphome
Copy link

Hey there @trvrnrth, mind taking a look at this pull request as it has been labeled with an integration (bme680_bsec) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@trvrnrth trvrnrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding the option.

@jesserockz jesserockz merged commit 142b33f into esphome:dev Feb 18, 2024
55 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants