Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xl9535 pin reads #6242

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix xl9535 pin reads #6242

merged 1 commit into from
Feb 19, 2024

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

Digital reads were incorrect because it was not checking per bit, but just against the pin number itself

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @mreditor97, mind taking a look at this pull request as it has been labeled with an integration (xl9535) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (342fb72) 53.70% compared to head (1f9457f) 53.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6242   +/-   ##
=======================================
  Coverage   53.70%   53.70%           
=======================================
  Files          50       50           
  Lines        9408     9408           
  Branches     1654     1654           
=======================================
  Hits         5053     5053           
  Misses       4056     4056           
  Partials      299      299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbx81 kbx81 enabled auto-merge (squash) February 19, 2024 03:31
@kbx81 kbx81 merged commit 967259a into dev Feb 19, 2024
57 checks passed
@kbx81 kbx81 deleted the jesserockz-2024-022 branch February 19, 2024 03:44
jesserockz added a commit that referenced this pull request Feb 19, 2024
@jesserockz jesserockz mentioned this pull request Feb 19, 2024
@jesserockz jesserockz mentioned this pull request Feb 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants