Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing timeout to "async_request" #6267

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add missing timeout to "async_request" #6267

merged 1 commit into from
Feb 21, 2024

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

A missed argument introduced in #5724 causes the dashboard to throw many crashes and breaks the adoption functionality.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz added this to the 2024.2.1 milestone Feb 21, 2024
@jesserockz jesserockz requested a review from a team as a code owner February 21, 2024 22:43
@kbx81 kbx81 merged commit 127cbde into dev Feb 21, 2024
57 checks passed
@kbx81 kbx81 deleted the jesserockz-2024-028 branch February 21, 2024 23:51
@jesserockz jesserockz mentioned this pull request Feb 22, 2024
13 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants