Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix throttle average nan handling #6275

Merged
merged 1 commit into from
Feb 25, 2024
Merged

fix throttle average nan handling #6275

merged 1 commit into from
Feb 25, 2024

Conversation

ssieb
Copy link
Member

@ssieb ssieb commented Feb 23, 2024

What does this implement/fix?

If the throttle_average filter receives no values during the interval, it publishes a NaN value. That can break things and doesn't really make sense. Now it won't publish a value if it didn't receive any.
I don't think this would be a breaking change, since it's very unlikely that anyone would be relying on this.
The current functionality is breaking configs.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.53%. Comparing base (4d8b5ed) to head (471d49f).
Report is 18 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6275      +/-   ##
==========================================
- Coverage   53.70%   53.53%   -0.17%     
==========================================
  Files          50       50              
  Lines        9408     9421      +13     
  Branches     1654     1652       -2     
==========================================
- Hits         5053     5044       -9     
- Misses       4056     4078      +22     
  Partials      299      299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit 77916d0 into esphome:dev Feb 25, 2024
305 checks passed
jesserockz pushed a commit that referenced this pull request Feb 25, 2024
Co-authored-by: Samuel Sieb <samuel@sieb.net>
@jesserockz jesserockz mentioned this pull request Feb 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
@ssieb ssieb deleted the throttle branch March 11, 2024 00:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants