Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RP2040 SPI pin validation #6277

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Feb 24, 2024

What does this implement/fix?

Quick fix to correct pins usable for SPI1

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @clydebarrow, @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (spi) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@kbx81 kbx81 added this to the 2024.2.1 milestone Feb 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.63%. Comparing base (4d8b5ed) to head (8cabd1d).
Report is 18 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6277      +/-   ##
==========================================
- Coverage   53.70%   53.63%   -0.08%     
==========================================
  Files          50       50              
  Lines        9408     9421      +13     
  Branches     1654     1658       +4     
==========================================
  Hits         5053     5053              
- Misses       4056     4068      +12     
- Partials      299      300       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbx81 kbx81 merged commit 4a54af0 into esphome:dev Feb 24, 2024
91 checks passed
@kbx81 kbx81 deleted the fix-rp2040-spi-pin-validation branch February 24, 2024 06:31
jesserockz pushed a commit that referenced this pull request Feb 25, 2024
@jesserockz jesserockz mentioned this pull request Feb 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants