New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AT581x component #6297
Conversation
Hey there @X-Ryl669, CODEOWNERS = ["@X-Ryl669"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6297 +/- ##
==========================================
- Coverage 53.70% 53.49% -0.22%
==========================================
Files 50 50
Lines 9408 9524 +116
Branches 1654 1685 +31
==========================================
+ Hits 5053 5095 +42
- Misses 4056 4120 +64
- Partials 299 309 +10 ☔ View full report in Codecov by Sentry. |
Hey there @niklasweber, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @regevbr, @sebcaps, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @descipher, mind taking a look at this pull request as it has been labeled with an integration ( |
dd35fe4
to
6d6ab5a
Compare
6dc9c61
to
39cbcde
Compare
The failing CI test is completely random (and unrelated to the code). I think it's a CI failure |
fe1a486
to
1759822
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing the code and how it actually works, I don't think this entire component needs its own binary_sensor platform and the detection_pin
config item.
Setting up the main component, and settings and power switch is fine, but for detecting motion, the user can just set up a gpio
binary sensor on that pin.
8949e23
to
1fd4c6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making that change.
What does this implement/fix?
This adds support for the AT581x 5.8GHz radar that's found in ESP32S3-BOX-3 device.
It's a very power efficient human detection device that configurable via I2C.
Types of changes
Related issue or feature (if applicable):
fixesPull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3646
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: