Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI schema now uses typed_schema with type key #6353

Merged
merged 5 commits into from Mar 12, 2024

Conversation

clydebarrow
Copy link
Contributor

What does this implement/fix?

SPI schema now uses typed_schema with type key to choose between single and quad. This improves
error reporting.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3676

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
spi:
  - id: spi_id_1
    clk_pin:
      number: GPIO7
      allow_other_uses: false
    mosi_pin: GPIO6
    interface: hardware
  - id: quad_spi
    type: quad
    clk_pin: 47
    interface: spi3
    data_pins:
      - number: 40
        allow_other_uses: false
      - 41
      - 42
      - 43
  - id: spi_id_3
    clk_pin: 8
    mosi_pin: 9
    interface: any

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (spi) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.50%. Comparing base (4d8b5ed) to head (82ba7e0).
Report is 89 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6353      +/-   ##
==========================================
- Coverage   53.70%   53.50%   -0.21%     
==========================================
  Files          50       50              
  Lines        9408     9515     +107     
  Branches     1654     1683      +29     
==========================================
+ Hits         5053     5091      +38     
- Misses       4056     4117      +61     
- Partials      299      307       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit 782d662 into esphome:dev Mar 12, 2024
91 checks passed
@jesserockz jesserockz mentioned this pull request Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
@clydebarrow clydebarrow deleted the quad_spi branch April 24, 2024 00:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants