Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make USE_HOST compilable on msys2 #6359

Merged
merged 1 commit into from Mar 12, 2024
Merged

Conversation

maruel
Copy link
Contributor

@maruel maruel commented Mar 12, 2024

What does this implement/fix?

Makes it possible to compile parts of esphome when using USE_HOST from within msys2. This is used by https://github.com/maruel/ellee to simulate an addressable_lambda effect at the console.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • USE_HOST :)

Example entry for config.yaml:

light:
  - effects:
      - addressable_lambda:
          lambda: |-
            const auto v = half_sin8(128);
            printf("%d\n", v);
            exit(0);

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@maruel maruel requested a review from a team as a code owner March 12, 2024 18:47
Copy link
Contributor

@clydebarrow clydebarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being a Windows user, I can't test, but since it has zero impact on anything else it LGTM.

@maruel
Copy link
Contributor Author

maruel commented Mar 12, 2024

Apologies for the force pushed update, I had used an incorrect author email address.

@clydebarrow clydebarrow merged commit d3a028f into esphome:dev Mar 12, 2024
55 checks passed
@maruel maruel deleted the win32_host branch March 12, 2024 20:23
@jesserockz jesserockz mentioned this pull request Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants