Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation for uponor_smatrix without time component #6389

Merged
merged 2 commits into from Mar 17, 2024

Conversation

kroimon
Copy link
Contributor

@kroimon kroimon commented Mar 17, 2024

What does this implement/fix?

Adds missing ifdef guard. Please also cherry-pick into current beta!

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): N/A

Pull request in esphome-docs with documentation (if applicable): N/A

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.50%. Comparing base (4d8b5ed) to head (3de5751).
Report is 213 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6389      +/-   ##
==========================================
- Coverage   53.70%   53.50%   -0.20%     
==========================================
  Files          50       50              
  Lines        9408     9516     +108     
  Branches     1654     1683      +29     
==========================================
+ Hits         5053     5092      +39     
- Misses       4056     4117      +61     
- Partials      299      307       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssieb ssieb added this to the 2024.3.0b3 milestone Mar 17, 2024
jesserockz
jesserockz previously approved these changes Mar 17, 2024
@jesserockz jesserockz merged commit c24946e into esphome:dev Mar 17, 2024
55 checks passed
@kroimon kroimon deleted the uponor_smatrix_timefix branch March 17, 2024 21:01
jesserockz added a commit that referenced this pull request Mar 18, 2024
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@jesserockz jesserockz mentioned this pull request Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants