New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for time entities #6399
Conversation
Hey there @RFDarter, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration ( |
Can you take a look at #6424 ? I see you also used strptime. This function eliminates 1M devices from ESPHome because it uses std::regex... Smart plugs, etc. With OTA there is max 500k space and even a barebone config is nearly that big. |
Then you need to call DateTimeBase::strptime instead, Which does not exists until this is merged. Can't you move it there in your PR? And this can be cancelled then. |
Ignore my last comment, putting ifdefs in time.h. strptime will stay there. |
Converting to draft as I need to add the |
Depends on #6468 |
Hey there @RFDarter, mind taking a look at this pull request as it has been labeled with an integration ( |
What does this implement/fix?
Adds support for
time
entities. This is pretty much the same asdate
entities with the obvious difference.Related PRs:
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3748
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: