Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI: Make some validation failures give more useful messages. #6413

Merged
merged 6 commits into from Mar 21, 2024

Conversation

clydebarrow
Copy link
Contributor

@clydebarrow clydebarrow commented Mar 20, 2024

What does this implement/fix?

For example, specifying data_pins without type: quad used to say:

  [data_pins] is an invalid option for [spi]. Please check the indentation.

Now it says:

  'data_pins' should be used with 'type: quad' only.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated in esphome-docs.
    choice is handled by a typed schema

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (spi) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.49%. Comparing base (4d8b5ed) to head (d56f334).
Report is 244 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6413      +/-   ##
==========================================
- Coverage   53.70%   53.49%   -0.22%     
==========================================
  Files          50       50              
  Lines        9408     9520     +112     
  Branches     1654     1684      +30     
==========================================
+ Hits         5053     5093      +40     
- Misses       4056     4119      +63     
- Partials      299      308       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jesserockz jesserockz merged commit d0ced34 into esphome:dev Mar 21, 2024
93 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
@clydebarrow clydebarrow deleted the spi branch April 24, 2024 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants