-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IRK support to ble_rssi #6422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6422 +/- ##
==========================================
+ Coverage 53.70% 54.18% +0.47%
==========================================
Files 50 50
Lines 9408 9579 +171
Branches 1654 1687 +33
==========================================
+ Hits 5053 5190 +137
- Misses 4056 4065 +9
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
3 tasks
jesserockz
requested changes
Mar 24, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
jesserockz
reviewed
May 7, 2024
jesserockz
approved these changes
May 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Most modern smartphones use use a privacy feature called Resolvable Private Addresses to avoid BLE tracking. However if you know the devices "Identity Resolving Key" (IRK), you can check if the generated private MAC address belongs to the device with the IRK.
This PR adds an option to the
ble_rssi
sensor to configure the IRK.There is no support to obtain the key. You will have to use one of the options described here: https://espresense.com/beacons
Once you have the IRK, configuration is similar to the other methods for the
ble_rssi
binary sensor.Implementation is almost the same as in
ble_presence
(#6335).Types of changes
Related issue or feature (if applicable): feature (as requested in esphome/feature-requests#2285)
Pull request in esphome-docs with documentation: esphome/esphome-docs#3707
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: