Store preferences in disk file on host platform #6428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 chars get used very quickly when the user uses a few special characters in the version string. Eg. `Gázkazán 1-2-4 PID vezérlés` requires double amount of chars: `G\303\241zkaz\303\241n 1-2-4 PID vez\303\251rl\303\251s`.
Use hash to compare project versions.
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
jesserockz
reviewed
Mar 25, 2024
| fs::create_directories(this->filename_); | ||
| this->filename_.append("/"); | ||
| this->filename_.append(App.get_name()); | ||
| this->filename_.append(".json"); |
There was a problem hiding this comment.
Based on the below code, this file is binary, not json?
There was a problem hiding this comment.
Ah, yes. JSON seemed like a Good Idea (which in Python it would have been) then I decided that was over-engineering.
clydebarrow
commented
Mar 25, 2024
jesserockz
approved these changes
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: