Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This broke in 25ab6f0 because
read_config_file
was no longer being called. It was missed thatread_config_file
will check theCORE.vscode
andCORE.ace
globals, and in some cases instead of reading a config file from disk, it will print an event to stdout, and than decode json from stdin to get the contents of the yaml.This PR removes
read_config_file
since its no longer used, which removes more of the globalCORE.ace
andCORE.vscode
checks.There are still two places where these global checks remain that should be removed, but they are a bit harder to remove and not contemplated in this PR
I added some more typing since it was very hard to follow what was going on as the variables names were not obvious.
Types of changes
Related issue or feature (if applicable): fixes esphome/issues#5533
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: