Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temperature for QMC5883L #6456

Merged
merged 6 commits into from Apr 3, 2024
Merged

Conversation

tronikos
Copy link
Contributor

@tronikos tronikos commented Apr 1, 2024

What does this implement/fix?

Add temperature for QMC5883L
Special thanks to @elmoret

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3730

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.43%. Comparing base (4d8b5ed) to head (8d21605).
Report is 277 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6456      +/-   ##
==========================================
- Coverage   53.70%   53.43%   -0.28%     
==========================================
  Files          50       50              
  Lines        9408     9529     +121     
  Branches     1654     1684      +30     
==========================================
+ Hits         5053     5092      +39     
- Misses       4056     4128      +72     
- Partials      299      309      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probot-esphome probot-esphome bot removed the small-pr label Apr 1, 2024
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, please add the new sensor entry to the tests in tests/components/qmc5883l/*.yaml

@esphome
Copy link

esphome bot commented Apr 2, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome esphome bot marked this pull request as draft April 2, 2024 02:43
@tronikos tronikos marked this pull request as ready for review April 2, 2024 14:46
@esphome esphome bot requested a review from jesserockz April 2, 2024 14:46
@jesserockz jesserockz merged commit 96f4c70 into esphome:dev Apr 3, 2024
54 checks passed
@tronikos tronikos deleted the qmc5883l_temperature branch April 4, 2024 07:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants