Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NOLINT on inclusive-language check #6464

Merged
merged 2 commits into from Apr 3, 2024
Merged

Fix NOLINT on inclusive-language check #6464

merged 2 commits into from Apr 3, 2024

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Apr 2, 2024

What does this implement/fix?

Sometimes we have to reference library/sdk variables that use the terms whitelist/blacklist/slave so we need to be able to ignore this until those references are updated upstream.

See #6463 for an example

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

kbx81
kbx81 previously approved these changes Apr 2, 2024
@jesserockz jesserockz merged commit 02632f0 into dev Apr 3, 2024
54 checks passed
@jesserockz jesserockz deleted the jesserockz-2024-076 branch April 3, 2024 02:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants