Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rmt_channel to remote_transmitter and remote_receiver #6497

Merged
merged 3 commits into from Apr 9, 2024

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Apr 8, 2024

What does this implement/fix?

This adds an optional rmt_channel to the remote_transmitter and remote_receiver components. It also moves and reuses the RMT_CHANNELS list per variant.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3745

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Apr 8, 2024

Hey there @jesserockz,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@jesserockz"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@jesserockz jesserockz added this to the 2024.4.0b1 milestone Apr 8, 2024
@kbx81 kbx81 merged commit c66b2c5 into dev Apr 9, 2024
82 checks passed
@kbx81 kbx81 deleted the jesserockz-2024-080 branch April 9, 2024 01:53
This was referenced Apr 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants