Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextion - Review types #6565

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Nextion - Review types #6565

merged 2 commits into from
Apr 18, 2024

Conversation

edwardtfn
Copy link
Contributor

@edwardtfn edwardtfn commented Apr 17, 2024

What does this implement/fix?

This reviews types used in multiple places on Nextion component, which will result in a better memory management but, mostly, on preventing unexpected results when an invalid value is sent to Nextion display. The function calls will now enforce the numeric ranges supported by Nextion or at least will manage this better than before.

This was part of #6192 which I'm breaking down.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): N/A

Pull request in esphome-docs with documentation (if applicable): N/A

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

N/A

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

This reviews types used in multiple places on Nextion component, which will result in a better memory management but, mostly, on preventing unexpected results when an invalid value is sent to Nextion display.
The function calls will now enforce the numeric ranges supported by Nextion or at least will manage this better than before.

This was part of esphome#6192 which I'm breaking down.
@probot-esphome
Copy link

Hey there @SenexCrenshaw, mind taking a look at this pull request as it has been labeled with an integration (nextion) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.38%. Comparing base (4d8b5ed) to head (17ad48f).
Report is 406 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6565      +/-   ##
==========================================
- Coverage   53.70%   53.38%   -0.33%     
==========================================
  Files          50       50              
  Lines        9408     9538     +130     
  Branches     1654     1679      +25     
==========================================
+ Hits         5053     5092      +39     
- Misses       4056     4138      +82     
- Partials      299      308       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit 197f9d6 into esphome:dev Apr 18, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants