Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tuya Climate] Fix compilation error caused by codegen #6568

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

zry98
Copy link
Contributor

@zry98 zry98 commented Apr 17, 2024

What does this implement/fix?

This fixes compilation error in Tuya Climate component described in esphome/issues#5707

which is caused by multiple errors in the code generator introduced by the commit be23153

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#5707

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.43%. Comparing base (4d8b5ed) to head (7e37abc).
Report is 406 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6568      +/-   ##
==========================================
- Coverage   53.70%   53.43%   -0.28%     
==========================================
  Files          50       50              
  Lines        9408     9538     +130     
  Branches     1654     1685      +31     
==========================================
+ Hits         5053     5097      +44     
- Misses       4056     4130      +74     
- Partials      299      311      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was a horrible mess. Thanks for fixing

@jesserockz jesserockz merged commit 51ed6d6 into esphome:dev Apr 17, 2024
55 checks passed
@jesserockz jesserockz added this to the 2024.4.1 milestone Apr 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuya climate compilation error
3 participants