Fix SHT3xd fails sometimes in 2024.4.0 #6592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) read serial number using clock stretching enabled register and if that fails try alternative clock stretching disabled register 2) add error codes to setup show in dump_config()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6592 +/- ##
==========================================
- Coverage 53.70% 53.43% -0.28%
==========================================
Files 50 50
Lines 9408 9537 +129
Branches 1654 1685 +31
==========================================
+ Hits 5053 5096 +43
- Misses 4056 4130 +74
- Partials 299 311 +12 ☔ View full report in Codecov by Sentry. |
jesserockz
requested changes
Apr 22, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
|
@jesserockz - I committed your suggested changes. This should bring things back to where they were. I am seeing if I can resolve issue#5303 - hopefully ready for May. Thanks |
jesserockz
approved these changes
Apr 22, 2024
|
Thanks for this!! I rolled back to 2024.3 as I had failures at random times with the sensor. Looking forward to the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Update to this component in release 2024.4.0 caused failure for some users on reading serial number.
This fix reinstates original register for reading serial number and if this fails the alternate is used. Error codes have been added to setup and are shown in dump_config
Types of changes
Related issue or feature (if applicable): fixes esphome/issues issue#5710
User that raised issue has tested fix successfully plus another user
Pull request in esphome-docs with documentation (if applicable): NA
Test Environment
Example entry for
config.yaml:NA
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: