-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #6614- use background_color, improve anti-aliasing #6618
Conversation
Draw background for selected and unselected menu entries
Hey there @MrMDavidson, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6618 +/- ##
==========================================
- Coverage 53.70% 53.45% -0.26%
==========================================
Files 50 50
Lines 9408 9543 +135
Branches 1654 1685 +31
==========================================
+ Hits 5053 5101 +48
- Misses 4056 4131 +75
- Partials 299 311 +12 ☔ View full report in Codecov by Sentry. |
What does this implement/fix?
For anti-aliased fonts, there is a background colour available in the menu code, so use it instead of inverting the foreground colour - should have been in #6614.
Also always draw a background for a menu item.
Improve rendering of anti-aliased fonts.
The net effect is to change this:
to this:
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: