Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #6614- use background_color, improve anti-aliasing #6618

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

clydebarrow
Copy link
Contributor

What does this implement/fix?

For anti-aliased fonts, there is a background colour available in the menu code, so use it instead of inverting the foreground colour - should have been in #6614.

Also always draw a background for a menu item.

Improve rendering of anti-aliased fonts.

The net effect is to change this:
Screenshot 2024-04-24 at 11 16 31 am

to this:

Screenshot 2024-04-24 at 11 16 02 am

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • Host

Example entry for config.yaml:

# Example config.yaml
color:
  - id: light_red
    hex: FF3340
  - id: light_blue
    hex: 3340FF

graphical_display_menu:
  id: my_graphical_display_menu
  background_color: light_blue
  foreground_color: light_red
  display: vnc_display
  on_redraw:
    then:
      component.update: vnc_display
  active: false
  font: roboto
  mode: rotary
  items:
    - type: Label
      text: Menu Item 1
    - type: Label
      text: Menu Item 2

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Draw background for selected and unselected menu entries
@probot-esphome
Copy link

Hey there @MrMDavidson, mind taking a look at this pull request as it has been labeled with an integration (graphical_display_menu) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (font) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (4d8b5ed) to head (afb838d).
Report is 470 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6618      +/-   ##
==========================================
- Coverage   53.70%   53.45%   -0.26%     
==========================================
  Files          50       50              
  Lines        9408     9543     +135     
  Branches     1654     1685      +31     
==========================================
+ Hits         5053     5101      +48     
- Misses       4056     4131      +75     
- Partials      299      311      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyrobi nagyrobi added this to the 2024.5.0b1 milestone Apr 25, 2024
@jesserockz jesserockz merged commit 0662c5e into esphome:dev Apr 25, 2024
56 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants