Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[template/text] Fix lambda config #6655

Merged
merged 9 commits into from
Apr 29, 2024
Merged

Conversation

asergunov
Copy link
Contributor

@asergunov asergunov commented Apr 29, 2024

What does this implement/fix?

The template text platform was not working if lambda specified. The problem is default=False in schema producing the config option even if user is not specifying it, but on validation step we checking if this option doesn't exists in config.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

text:
  - platform: template
    mode: text
    lambda: |
      return std::string{"Hello"};

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.05%. Comparing base (4d8b5ed) to head (553026e).
Report is 493 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6655      +/-   ##
==========================================
+ Coverage   53.70%   54.05%   +0.34%     
==========================================
  Files          50       50              
  Lines        9408     9554     +146     
  Branches     1654     1687      +33     
==========================================
+ Hits         5053     5164     +111     
- Misses       4056     4066      +10     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

esphome/components/template/text/__init__.py Outdated Show resolved Hide resolved
esphome/components/template/text/__init__.py Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft April 29, 2024 05:20
@esphome
Copy link

esphome bot commented Apr 29, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Co-authored-by: Clyde Stubbs <2366188+clydebarrow@users.noreply.github.com>
@clydebarrow clydebarrow changed the title Fix template text generatio in lambda mode [template/text] Fix lambda config Apr 29, 2024
Co-authored-by: Clyde Stubbs <2366188+clydebarrow@users.noreply.github.com>
@asergunov asergunov marked this pull request as ready for review April 29, 2024 09:39
@esphome esphome bot requested a review from clydebarrow April 29, 2024 09:39
@clydebarrow clydebarrow merged commit 73bb4aa into esphome:dev Apr 29, 2024
56 checks passed
@asergunov asergunov deleted the template_text_fix branch April 29, 2024 11:17
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants