-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[template/text] Fix lambda config #6655
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6655 +/- ##
==========================================
+ Coverage 53.70% 54.05% +0.34%
==========================================
Files 50 50
Lines 9408 9554 +146
Branches 1654 1687 +33
==========================================
+ Hits 5053 5164 +111
- Misses 4056 4066 +10
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
clydebarrow
requested changes
Apr 29, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Clyde Stubbs <2366188+clydebarrow@users.noreply.github.com>
clydebarrow
changed the title
Fix template text generatio in lambda mode
[template/text] Fix lambda config
Apr 29, 2024
Co-authored-by: Clyde Stubbs <2366188+clydebarrow@users.noreply.github.com>
clydebarrow
approved these changes
Apr 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The template text platform was not working if
lambda
specified. The problem isdefault=False
in schema producing the config option even if user is not specifying it, but on validation step we checking if this option doesn't exists in config.Types of changes
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).