Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Ensure that a generated ID name is distinct from its type. #6706

Merged
merged 1 commit into from
May 9, 2024

Conversation

clydebarrow
Copy link
Contributor

What does this implement/fix?

If an ID is created with a type in the global namespace, i.e. without a :: separator, the first instance generated will be identical to the type, leading to compile-time errors.

This PR checks for that case and disambiguates the name.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@clydebarrow clydebarrow requested a review from a team as a code owner May 9, 2024 00:59
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.24%. Comparing base (4d8b5ed) to head (fae3b70).
Report is 541 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6706      +/-   ##
==========================================
+ Coverage   53.70%   54.24%   +0.53%     
==========================================
  Files          50       50              
  Lines        9408     9581     +173     
  Branches     1654     1688      +34     
==========================================
+ Hits         5053     5197     +144     
- Misses       4056     4060       +4     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz added this to the 2024.5.0b3 milestone May 9, 2024
@jesserockz jesserockz merged commit afe8118 into esphome:dev May 9, 2024
57 checks passed
@jesserockz jesserockz mentioned this pull request May 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants