Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ili9xxx] Fix init for GC9A01A #6913

Merged
merged 1 commit into from
Jun 17, 2024
Merged

[ili9xxx] Fix init for GC9A01A #6913

merged 1 commit into from
Jun 17, 2024

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

This changes the init_lcd function to be virtual so that the GC9A01A can override it and not implement the ILI9XXX_DELAY instruction.

The GC9A01A has a function already that uses 0xFF (it is not known what it means, but it is important).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @clydebarrow, @nielsnl68, mind taking a look at this pull request as it has been labeled with an integration (ili9xxx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit 253303f into dev Jun 17, 2024
57 checks passed
@jesserockz jesserockz deleted the jesserockz-2024-2331 branch June 17, 2024 01:01
jesserockz added a commit that referenced this pull request Jun 17, 2024
@jesserockz jesserockz mentioned this pull request Jun 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants