Addressing first install issue noted by #580, #666, others. #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers. Voluptuous 0.11.7 appears to be explodey with the current live version of esphome.
|
The 4th travis build failed with something entirely unrelated to my change. |
|
I believe this ticket is closed because the dev branch has been changed to support voluptious 0.11.7, yet the requirements.txt in dev reads I think the right PR for dev is a patch to requirements.txt |
|
Whoops, you're right @donpdonp, thanks! Idea behind that commit was to pin voluptuous to a specific version so that we would not have the same issue again, but obiously messed that up. |
OttoWinter
added a commit
that referenced
this pull request
Oct 15, 2019
silverchris
pushed a commit
to silverchris/esphome
that referenced
this pull request
May 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voluptuous 0.11.7 appears to be explodey with the current live version of esphome.
Description:
Related issue (if applicable): fixes
esphome/issues#580
esphome/issues#666
esphome/issues#728
esphome/issues#693
esphome/issues#687
esphome/issues#679
esphome/issues#647
esphome/issues#644
esphome/issues#621
esphome/issues#591
esphome/issues#579
esphome/issues#578
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: