Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esphome/issues#947 - RGBW(W) white brightness #925

Merged
merged 1 commit into from Mar 12, 2020

Conversation

pauln
Copy link
Contributor

@pauln pauln commented Dec 25, 2019

Description:

Updates the as_rgbw() and as_rgbww() calculations to factor in the brightness as well as the white level, so that the white channels dim as expected when the brightness is changed.

Related issue (if applicable): fixes #947

Pull request in esphome-docs with documentation (if applicable): N/A

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@glmnet
Copy link
Member

glmnet commented Feb 15, 2020

LGTM

@jjross
Copy link

jjross commented Feb 23, 2020

First, thanks for all the good work.

When do we think this will be added to the mainline code? I'm affected by the bug.

@brandond brandond merged commit 1106908 into esphome:dev Mar 12, 2020
@lock lock bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGBW(W) lights ignore brightness on white channel(s)
5 participants