Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicker to hover with current brightness as the middle value #348

Closed
Joshfindit opened this issue Jul 28, 2019 · 1 comment
Closed

Flicker to hover with current brightness as the middle value #348

Joshfindit opened this issue Jul 28, 2019 · 1 comment

Comments

@Joshfindit
Copy link

Describe the problem you have/What new integration you would like

When flicker is called, it dims significantly, seeming to make the current brightness the max brightness, then the natural flicker rarely if ever lands on the brightness again.

Please describe your use case for this integration and alternatives you've tried:

Ideally, I would like if I was able to set the brightness to an arbitrary value, then have a flickering 'candle light' that stays around that brightness

Additional context

There will also be logic to consider when brightness starts at 100%. I would still prefer that 100% be the 'average' brightness. Possibly with a mapping like 101% = 99%, 105% = 95%, 140% = 60%, etc

Both this and esphome/issues#555 may end up being closed with the same code change

@OttoWinter
Copy link
Member

Yeah that's what the flicker effect is supposed to do - I will merge this into the mentioned issue, because it's not really a feature request.

OttoWinter added a commit to esphome/esphome that referenced this issue Oct 13, 2019
OttoWinter added a commit to esphome/esphome that referenced this issue Oct 18, 2019
* Improve addressable light transition behavior

Fixes esphome/issues#555

* Improve addressable flicker effect

See also esphome/feature-requests#348

* Update addressable_light_effect.h

* Refactor

* Format

* Prevent divide by zero

* Fixes
@esphome esphome locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants