Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error with "update_on_boot" of my9231 #450

Closed
freegink opened this issue Jun 16, 2019 · 2 comments
Closed

Compile error with "update_on_boot" of my9231 #450

freegink opened this issue Jun 16, 2019 · 2 comments

Comments

@freegink
Copy link

Operating environment/Installation (Hass.io/Docker/pip/etc.): pip

ESP (ESP32/ESP8266, Board/Sonoff): Sonoff B1 R2

Affected component: My9231

Description of problem:
After adding property "update_on_boot", ESPHome indicated "update_on_boot" is an invalid option for my9321.

And I checked the source code, it doesn't seem that the const "CONF_UPDATE_ON_BOOT" was used anywhere. Correct me if I'm wrong.

Problem-relevant YAML-configuration entries:

my9231:
  data_pin: GPIO12
  clock_pin: GPIO14
  num_channels: 6
  num_chips: 2
  update_on_boot: false

Traceback (if applicable):

Failed config

my9231:
  - [source sonoff_b1_r2.yaml:27]
    data_pin: GPIO12
    clock_pin: GPIO14
    num_channels: 6
    num_chips: 2

    [update_on_boot] is an invalid option for [0]. Please check the indentation.
    update_on_boot: True

Additional information and things you've tried:

@OttoWinter
Copy link
Member

Ah yes, I think I removed the option in 1.13 because ESPHome now can restore state from flash. Will update the documentation to remove that option.

OttoWinter added a commit to esphome/esphome-docs that referenced this issue Sep 1, 2019
@john-arvid
Copy link

Maybe also change the note on this one?
https://esphome.io/components/output/my9231.html?highlight=my9291#sonoff-b1-configuration-example

And I think that since the restore state is used it can read the last state from flash instead from the my9231. (Not that it ever read from the my9231 chip, but it will store the last state it sent to the my9231)

@esphome esphome locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants