Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextion Picture arguments mixed up #613

Closed
Andoramb opened this issue Aug 23, 2019 · 0 comments
Closed

Nextion Picture arguments mixed up #613

Andoramb opened this issue Aug 23, 2019 · 0 comments

Comments

@Andoramb
Copy link

Operating environment/Installation (Hass.io/Docker/pip/etc.):
Vero4k+

ESP (ESP32/ESP8266, Board/Sonoff):
Wemos D1 mini

Affected component:
nextion.cpp

Description of problem:
I think the implementation of displaying a picture is wrong, the order is mixed up:

From Nextion Instruction Set:
pic x, y, picid

Inside nextion.cpp:

void Nextion::display_picture(int picture_id, int x_start, int y_start) {
  this->send_command_printf("pic %d %d %d", picture_id, x_start, y_start);

Problem-relevant YAML-configuration entries:
for example

it.display_picture(100,420,380)

picture ID 100 mixed up with with x y coordinates

Logs (if applicable):
N/A

Additional information and things you've tried:

@esphome esphome locked and limited conversation to collaborators Oct 19, 2019
silverchris pushed a commit to silverchris/esphome that referenced this issue May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant