-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding non-shared BLSTM layers in CTC #173
Conversation
I'm observing some small improvement when I added a non-shared BLSTM layer before the CTC objective. |
src/bin/asr_train.py
Outdated
# ctc | ||
parser.add_argument('--ctype', default='warpctc', type=str, | ||
choices=['warpctc', 'chainer', 'blstm'], | ||
help='Type of CTC architecture.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name blstm
is a little bit confusing.
How about adding non-shared layer when clayers > 0
while keeping ctype=warpctc
?
src/nets/e2e_asr_attctc.py
Outdated
hy, cy, hs = self.nblstm(None, None, hs) | ||
hs = self.l_last(F.vstack(hs)) # (sum _utt frame_utt) x dim | ||
hs = F.split_axis(hs, np.cumsum(ilens[:-1]), axis=0) | ||
del hy, cy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_, _, hs = self.nblstm(None, None, hs)
src/nets/e2e_asr_attctc.py
Outdated
hy, cy, hs = self.nblstm(None, None, hs) | ||
hs = self.l_last(F.vstack(hs)) # (sum _utt frame_utt) x dim | ||
hs = F.split_axis(hs, np.cumsum(hlen[:-1]), axis=0) | ||
del hy, cy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_, _, hs = self.nblstm(None, None, hs)
src/nets/e2e_asr_attctc_th.py
Outdated
|
||
hpack = pack_padded_sequence(hpad, ilens, batch_first=True) | ||
hs, (hy, cy) = self.nblstm(hpack) | ||
del hy, cy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hs, _ = self.nblstm(hpack)
src/nets/e2e_asr_attctc_th.py
Outdated
|
||
hpack = pack_padded_sequence(hpad, ilens, batch_first=True) | ||
hs, (hy, cy) = self.nblstm(hpack) | ||
del hy, cy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hs, _ = self.nblstm(hpack)
LGTM |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is closed. Please re-open if needed. |
No description provided.