-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe update to be compatible with pytorch #25
Conversation
I think it is better to merge #9 before this PR to avoid new conflicts. |
@kan-bayashi is this ready for merging? |
@sw005320 Now it can be merged. |
|
Can you also change chainer/pytorch switch as follows?
see https://github.com/espnet/espnet/blob/master/egs/wsj/asr1/run.sh |
Finished. |
Thanks for fixing the indent. Can you also fix that of WSJ run.sh (or already done?) |
Conflicts: egs/wsj/asr1/run.sh
Done. |
@ShigekiKarita can you also review src/nets/e2e_asr_attctc_th.py? |
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Under construction.