Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe update to be compatible with pytorch #25

Merged
merged 14 commits into from
Dec 25, 2017

Conversation

kan-bayashi
Copy link
Member

Under construction.

@ShigekiKarita
Copy link
Member

I think it is better to merge #9 before this PR to avoid new conflicts.

@sw005320
Copy link
Contributor

@kan-bayashi is this ready for merging?

@kan-bayashi
Copy link
Member Author

@sw005320 Now it can be merged.

@kan-bayashi kan-bayashi changed the title [WIP] Recipe update to be compatible with pytorch Recipe update to be compatible with pytorch Dec 24, 2017
@sw005320
Copy link
Contributor

  • @ShigekiKarita I didn't notice that the stage structure in the WSJ recipe was changed. I want to stick to the original structure (data preparation for test data and scoring are merged in one recognition stage). If it is OK, I will change it to the original structure. Then, with @kan-bayashi 's changes, all recipes have the consistent stage structure.
  • pytorch backend does not currently support vggblstnp architecture, and better to mention it and possibly make blstmp as default architecture for the pytorch case.

@sw005320
Copy link
Contributor

Can you also change chainer/pytorch switch as follows?

# switch backend
if [[ ${backend} == chainer ]]; then
    train_script=asr_train.py
    decode_script=asr_recog.py
else
    train_script=asr_train_th.py
    decode_script=asr_recog_th.py
fi

see https://github.com/espnet/espnet/blob/master/egs/wsj/asr1/run.sh

@kan-bayashi
Copy link
Member Author

Finished.
And I changed tab with space to clean up the code.

@sw005320
Copy link
Contributor

Thanks for fixing the indent. Can you also fix that of WSJ run.sh (or already done?)

@kan-bayashi
Copy link
Member Author

Done.

@sw005320
Copy link
Contributor

@ShigekiKarita can you also review src/nets/e2e_asr_attctc_th.py?

@ShigekiKarita
Copy link
Member

OK

Copy link
Member

@ShigekiKarita ShigekiKarita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sw005320 sw005320 merged commit d50a8c2 into espnet:master Dec 25, 2017
@ShigekiKarita ShigekiKarita mentioned this pull request Dec 25, 2017
@kan-bayashi kan-bayashi deleted the recipe_update branch December 25, 2017 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants