Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accented English Speech Recognition Challenge 2020 recipe (AESRC2020) #3898

Merged
merged 6 commits into from
Apr 13, 2022

Conversation

brianyan918
Copy link
Contributor

No description provided.

@mergify mergify bot added the ESPnet1 label Dec 22, 2021
@sw005320 sw005320 added ASR Automatic speech recogntion Recipe labels Dec 22, 2021
@sw005320 sw005320 added this to the v.0.10.5 milestone Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #3898 (ae42481) into master (ff7c051) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3898   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files         453      453           
  Lines       39576    39576           
=======================================
  Hits        31945    31945           
  Misses       7631     7631           
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 50.05% <ø> (ø)
test_python 67.16% <ø> (ø)
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the readme in the egs?

@kan-bayashi kan-bayashi modified the milestones: v.0.10.5, v.0.10.6 Dec 31, 2021
@ftshijt
Copy link
Collaborator

ftshijt commented Jan 4, 2022

Looks perfect to me. Thanks @brianyan918

@ftshijt
Copy link
Collaborator

ftshijt commented Jan 4, 2022

Sorry, a minor issue: could you also add a description in egs/README

@ftshijt
Copy link
Collaborator

ftshijt commented Jan 29, 2022

Just a reminder, please add update the description at egs2/README.md. After that, I can merge the PR

@brianyan918
Copy link
Contributor Author

brianyan918 commented Jan 29, 2022 via email

@mergify mergify bot added the README label Jan 29, 2022
@ftshijt
Copy link
Collaborator

ftshijt commented Jan 30, 2022

Could you also merge the latest PR to pass the CI tests? We added some version control for CI testing.

@ftshijt
Copy link
Collaborator

ftshijt commented Feb 2, 2022

Could you pull the latest master in espnet so as to fix the broken CI?

@kan-bayashi kan-bayashi modified the milestones: v.0.10.6, v.0.10.7 Feb 8, 2022
@kan-bayashi kan-bayashi modified the milestones: v.0.10.7, v.202205 Apr 11, 2022
@brianyan918
Copy link
Contributor Author

@sw005320 is this OK to merge?

@sw005320
Copy link
Contributor

Yes!
Thanks, @brianyan918!

@sw005320 sw005320 merged commit fba5041 into espnet:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion ESPnet1 README Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants