Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a checklist for PRs on recipe #4053

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Add a checklist for PRs on recipe #4053

merged 2 commits into from
Feb 10, 2022

Conversation

ftshijt
Copy link
Collaborator

@ftshijt ftshijt commented Feb 10, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #4053 (b3a70d4) into master (38939c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4053   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files         435      435           
  Lines       37425    37425           
=======================================
  Hits        30294    30294           
  Misses       7131     7131           
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 52.44% <ø> (ø)
test_python 66.61% <ø> (ø)
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38939c2...b3a70d4. Read the comment docs.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@sw005320 sw005320 added this to the v.0.10.7 milestone Feb 10, 2022
@ftshijt
Copy link
Collaborator Author

ftshijt commented Feb 10, 2022

Cool! Fixed

@sw005320
Copy link
Contributor

Thanks!
Let's maintain this document.

@sw005320
Copy link
Contributor

Thanks, @ftshijt!

@sw005320 sw005320 merged commit a571a4d into master Feb 10, 2022
@sw005320 sw005320 deleted the ftshijt-patch-1 branch February 10, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants