Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Updates #4064

Merged
merged 4 commits into from
Feb 12, 2022
Merged

Docker Updates #4064

merged 4 commits into from
Feb 12, 2022

Conversation

Fhrozen
Copy link
Member

@Fhrozen Fhrozen commented Feb 11, 2022

Docker updates:

  • Update containers with last python requirements
  • Simplify dockerfiles with multi-stage
  • Fix file names, and folder distribution

ToDo:

  • Add Github action for launching building when setup.py or make is updated/PR

@mergify mergify bot added the Docker label Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #4064 (5ef859b) into master (527e093) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4064   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files         435      435           
  Lines       37425    37425           
=======================================
  Hits        30294    30294           
  Misses       7131     7131           
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 52.44% <ø> (ø)
test_python 66.61% <ø> (ø)
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527e093...5ef859b. Read the comment docs.

@sw005320 sw005320 added this to the v.0.10.7 milestone Feb 12, 2022
@sw005320 sw005320 merged commit 2ad5b51 into espnet:master Feb 12, 2022
@sw005320
Copy link
Contributor

Thanks, @Fhrozen!

Add Github action for launching building when setup.py or make is updated/PR

Will you do that in the later PR?

@Fhrozen Fhrozen deleted the pr-docker branch February 12, 2022 10:00
@Fhrozen
Copy link
Member Author

Fhrozen commented Feb 12, 2022

@sw005320 yes. I am checking for the requirements to implement it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants