Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ASR recipe for VCTK dataset based on TTS's dataprep. #4088

Merged
merged 8 commits into from
Mar 11, 2022
Merged

Add ASR recipe for VCTK dataset based on TTS's dataprep. #4088

merged 8 commits into from
Mar 11, 2022

Conversation

kashikashi
Copy link
Contributor

PR for vctk asr recipe.

@mergify mergify bot added the ESPnet2 label Feb 18, 2022
@sw005320 sw005320 added ASR Automatic speech recogntion Recipe labels Feb 18, 2022
@sw005320 sw005320 added this to the v.0.10.7 milestone Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022 •
edited

Codecov Report

Merging #4088 (5daa351) into master (cb8181a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4088   +/-   ##
=======================================
  Coverage   80.46%   80.46%           
=======================================
  Files         444      444           
  Lines       38713    38713           
=======================================
  Hits        31149    31149           
  Misses       7564     7564
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 50.96% <ø> (ø)
test_python 66.59% <ø> (ø)
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot added the README label Feb 18, 2022
ftshijt
ftshijt reviewed Feb 19, 2022
View reviewed changes
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! I have some suggestions as follows

egs2/vctk/asr1/RESULTS.md Outdated Show resolved Hide resolved
egs2/vctk/asr1/conf/decode_asr.yaml Outdated Show resolved Hide resolved
egs2/vctk/asr1/conf/fbank.conf Outdated Show resolved Hide resolved
egs2/vctk/asr1/local/data_download.sh Outdated Show resolved Hide resolved
egs2/vctk/asr1/local/data_prep.sh Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2022

This pull request is now in conflict :(

@mergify mergify bot added the conflicts label Mar 2, 2022
@mergify mergify bot removed the conflicts label Mar 10, 2022
@kashikashi
Copy link
Contributor Author

Sorry for the delay.
I left dev=5 to keep the data compatible with TTS.
Instead, I also added a speaker open setting, which is often used in speech recognition.
This is based on the noisy-vctk setting.
I set the default setting to speaker open.

sw005320
sw005320 reviewed Mar 10, 2022
View reviewed changes
egs2/vctk/asr1/RESULTS.md Show resolved Hide resolved
egs2/vctk/asr1/RESULTS.md Show resolved Hide resolved
@ftshijt
Copy link
Collaborator

ftshijt commented Mar 11, 2022

LGTM! Many thanks for your contribution.

@ftshijt ftshijt merged commit b714fbe into espnet:master Mar 11, 2022
@kashikashi kashikashi deleted the vctk_asr1 branch March 14, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sw005320 sw005320 sw005320 left review comments

@ftshijt ftshijt ftshijt left review comments

Assignees
No one assigned
Labels
ASR Automatic speech recogntion ESPnet2 README Recipe
Projects
None yet
Milestone
v.202204
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kashikashi @ftshijt @sw005320