Automatic lyric recognition Recipe #4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4129 +/- ##
=======================================
Coverage 80.43% 80.43%
=======================================
Files 442 442
Lines 38557 38557
=======================================
Hits 31015 31015
Misses 7542 7542
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
The results seem promising, will merge the recipe first and update the results and pre-trained model in another PR |
simpleoier
reviewed
Mar 17, 2022
| @@ -39,13 +39,13 @@ class ApplyKmeans(object): | |||
| def __init__(self, km_path): | |||
| self.km_model = joblib.load(km_path) | |||
| self.nc = self.km_model.cluster_centers_.transpose() | |||
| self.nc_norm = (self.nc ** 2).sum(0, keepdims=True) | |||
| self.nc_norm = (self.nc**2).sum(0, keepdims=True) | |||
There was a problem hiding this comment.
Can you depress this modification?
There was a problem hiding this comment.
I think the issue comes from the newer black version. The results are identical here?
|
|
||
| def __call__(self, x): | ||
| if isinstance(x, torch.Tensor): | ||
| x = x.cpu().numpy() | ||
| probs = ( | ||
| (x ** 2).sum(1, keepdims=True) - 2 * np.matmul(x, self.nc) + self.nc_norm | ||
| (x**2).sum(1, keepdims=True) - 2 * np.matmul(x, self.nc) + self.nc_norm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 11-737 HW3
I will update pre-trained model and results later