Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iFaSNet for enhancement/separation tasks. #4130

Merged
merged 7 commits into from
Mar 21, 2022
Merged

Conversation

LiChenda
Copy link
Contributor

@LiChenda LiChenda commented Mar 4, 2022

This is an implemntation of iFaSNet.
The code is based on Yi Luo's implementation.
I also add a corresponding configuration file for CHiME4 recipe. A pretrained model on CHiME4 will be uploaded to hugginface in near future.

@mergify mergify bot added the ESPnet2 label Mar 4, 2022
@Emrys365
Copy link
Collaborator

Emrys365 commented Mar 4, 2022

Could you also add the original FasNet model?
They are based on the same codebase, and it would be convenient to have both models in ESPnet.

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #4130 (d3d65cf) into master (a04a98c) will increase coverage by 0.16%.
The diff coverage is 93.20%.

@@            Coverage Diff             @@
##           master    #4130      +/-   ##
==========================================
+ Coverage   80.43%   80.60%   +0.16%     
==========================================
  Files         442      450       +8     
  Lines       38557    39372     +815     
==========================================
+ Hits        31015    31735     +720     
- Misses       7542     7637      +95     
Flag Coverage Δ
test_integration_espnet1 67.13% <ø> (ø)
test_integration_espnet2 50.29% <14.88%> (-0.85%) ⬇️
test_python 66.98% <93.20%> (+0.46%) ⬆️
test_utils 24.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
espnet2/enh/layers/ifasnet.py 90.27% <90.27%> (ø)
espnet2/enh/layers/fasnet.py 92.85% <92.85%> (ø)
espnet2/enh/separator/fasnet_separator.py 96.29% <96.29%> (ø)
espnet2/enh/layers/dprnn.py 98.54% <96.36%> (-1.46%) ⬇️
espnet2/tasks/enh.py 99.08% <100.00%> (+<0.01%) ⬆️
espnet2/asr/decoder/transformer_decoder.py 95.08% <0.00%> (-1.56%) ⬇️
espnet2/tasks/asr.py 91.20% <0.00%> (-0.75%) ⬇️
espnet2/bin/mt_inference.py 0.00% <0.00%> (ø)
espnet2/asr/decoder/mlm_decoder.py 100.00% <0.00%> (ø)
espnet2/asr/encoder/longformer_encoder.py 80.62% <0.00%> (ø)
... and 7 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sw005320 sw005320 added SE Speech enhancement New Features labels Mar 4, 2022
@sw005320 sw005320 added this to the v.0.10.7 milestone Mar 4, 2022
@sw005320
Copy link
Contributor

sw005320 commented Mar 9, 2022

LGTM.
@Emrys365, if you're OK, you can marge it.

@LiChenda, it would be great if you prepare a pre-trained model and result later.

1 similar comment
@sw005320
Copy link
Contributor

sw005320 commented Mar 9, 2022

LGTM.
@Emrys365, if you're OK, you can marge it.

@LiChenda, it would be great if you prepare a pre-trained model and result later.

@LiChenda
Copy link
Contributor Author

Thanks for the comments! As @Emrys365 suggested, I also add the origin fasnet. The pretrained model will be uploaded soon.

@mergify mergify bot added the README label Mar 21, 2022
Copy link
Collaborator

@Emrys365 Emrys365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @LiChenda

@Emrys365 Emrys365 merged commit 1991a25 into espnet:master Mar 21, 2022
@LiChenda LiChenda deleted the fasnet branch May 19, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants